Run linkchecks regularly, instead of on PRs#6386
Merged
trexfeathers merged 10 commits intoSciTools:mainfrom Mar 28, 2025
Merged
Run linkchecks regularly, instead of on PRs#6386trexfeathers merged 10 commits intoSciTools:mainfrom
trexfeathers merged 10 commits intoSciTools:mainfrom
Conversation
![scitools-ci[bot]](https://avatars.githubusercontent.com/in/212324?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6386 +/- ##
=======================================
Coverage 89.80% 89.80%
=======================================
Files 90 90
Lines 23752 23752
Branches 4418 4418
=======================================
Hits 21331 21331
Misses 1672 1672
Partials 749 749 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pp-mo
changed the title
pp-mo
changed the title
trexfeathers
requested changes
Mar 27, 2025
Contributor
trexfeathers
left a comment
trexfeathers
left a comment
There was a problem hiding this comment.
A few changes for you, and one possible show-stopper.
Co-authored-by: Martin Yeo <40734014+trexfeathers@users.noreply.github.com>
Co-authored-by: Martin Yeo <40734014+trexfeathers@users.noreply.github.com>
trexfeathers
approved these changes
Mar 28, 2025
Contributor
|
Super, thanks for this exciting improvement @pp-mo! |
trexfeathers
dismissed
scitools-ci[bot]’s stale review
I consider the requested scitools-ci actions to be completed, except for SciTools/.github#65, which we will keep open until we have a MANIFEST.in template - planned for the future.
trexfeathers
added a commit
to trexfeathers/iris
that referenced
this pull request
Apr 30, 2025
* Add lychee-based linkcheck workflow. * Remove old nox-based per-PR linkcheck. * Remove nox-linkcheck from python-version-checks test. * Configure manifest to exclude the linkcheck ignores file. * Update .github/workflows/ci-linkchecks.yml Co-authored-by: Martin Yeo <40734014+trexfeathers@users.noreply.github.com> * Update .github/workflows/ci-linkchecks.yml Co-authored-by: Martin Yeo <40734014+trexfeathers@users.noreply.github.com> * Add links badge to README. * Test urls in all files python, exclude or replace failing urls in python. * Run checks every day, including weekends. * Apply Iris-friendly labels to linkcheck failure Issues. --------- Co-authored-by: Martin Yeo <40734014+trexfeathers@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the nox-based, per-PR link check with an occasional scheduled (or manually triggered) linkcheck.
This is based on "lychee", which can check the RSTs directly
Pros:
Cons:
:pep:,:PR:, and:Issue:, as seen (mostly) in whatsnews.github.com, but I have been able to re-include them by limiting the ignore github.com/[^/]*$, as the damage seemed to be mostly done by all the user ids